logging: Also set log level of logger handlers #7576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-truwase
requested review from
stas00
and removed request for
tjruwase and
tohtana
stas00
requested changes
Sep 22, 2025
Collaborator
There was a problem hiding this comment.
Thank you for this improvement, @eternalNight
For some reason I can't push into your PR, so please also change the function docstring to reflect this change. Suggesting:
"""Sets a log level in the passed `logger` and its handlers from string. e.g. "info" => `logging.INFO`
eternalNight
force-pushed
the
eternalNight/fix_log_level_setting
branch
from
6d41880 to
3c95858
Compare
After deepspeedai#7526 the default logger passes logs to a StreamHandler, which has its own log level. Changing the log level of the logger alone does not take effect in such case. Update the log level of all handlers when changing the parent logger's. Signed-off-by: Junjie Mao <[email protected]>
eternalNight
force-pushed
the
eternalNight/fix_log_level_setting
branch
from
3c95858 to
9621c73
Compare
Contributor
Author
Docstring updated. |
Collaborator
|
Thank you! |
stas00
approved these changes
Sep 23, 2025
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
After deepspeedai#7526 the default logger passes logs to a StreamHandler, which has its own log level. Changing the log level of the logger alone does not take effect in such case. Update the log level of all handlers when changing the parent logger's. Signed-off-by: Junjie Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #7526 the default logger passes logs to a StreamHandler, which has its own log level. Changing the log level of the logger alone does not take effect in such case.
Update the log level of all handlers when changing the parent logger's.