deepcompile: Record graph order using OrderedDict #7563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohtana
approved these changes
Sep 15, 2025
Collaborator
tohtana
left a comment
tohtana
left a comment
There was a problem hiding this comment.
Thank you @eternalNight!
Collaborator
|
@eternalNight Can you merge master into your branch? |
On clear, GraphOrder does not clears ordered_frames. That may confuses subsequent passes after the first iteration. Use an OrderedDict to record the mapping from frame IDs to other graph-related information. Also fix the type annotation of graph_order which is a list of (int , bool) tuples instead of a list of int. Signed-off-by: Junjie Mao <[email protected]>
auto-merge was automatically disabled
September 16, 2025 02:45
Head branch was pushed to by a user without write access
eternalNight
force-pushed
the
eternalNight/cleanup-graph-order
branch
from
f9eb44e to
a71a47d
Compare
Contributor
Author
Sure. Branch rebased. |
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
On clear, GraphOrder does not clears ordered_frames. That may confuses subsequent passes after the first iteration. Use an OrderedDict to record the mapping from frame IDs to other graph-related information. Also fix the type annotation of graph_order which is a list of (int , bool) tuples instead of a list of int. Signed-off-by: Junjie Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On clear, GraphOrder does not clears ordered_frames. That may confuses subsequent passes after the first iteration.
Use an OrderedDict to record the mapping from frame IDs to other graph-related information.
Also fix the type annotation of graph_order which is a list of (int , bool) tuples instead of a list of int.