Fix zenflow_torch_adam.py #7544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffra
approved these changes
Sep 3, 2025
Signed-off-by: Stas Bekman <[email protected]>
Flakes342
pushed a commit
to Flakes342/DeepSpeed
that referenced
this pull request
Sep 9, 2025
`_disable_dynamo_if_unsupported` fallback wasn't getting created under certain conditions. This PR is fixing this. Also removed debug print. Fixes issue installing deepspeed on torch 2.4 and 2.1 that triggered this: ``` deepspeedai#42 15.84 Traceback (most recent call last): deepspeedai#42 15.84 File "<string>", line 2, in <module> deepspeedai#42 15.84 File "<pip-setuptools-caller>", line 34, in <module> deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/setup.py", line 40, in <module> deepspeedai#42 15.84 from op_builder import get_default_compute_capabilities, OpBuilder deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/op_builder/__init__.py", line 18, in <module> deepspeedai#42 15.84 import deepspeed.ops.op_builder # noqa: F401 # type: ignore deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/__init__.py", line 25, in <module> deepspeedai#42 15.84 from . import ops deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/ops/__init__.py", line 6, in <module> deepspeedai#42 15.84 from . import adam deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/ops/adam/__init__.py", line 9, in <module> deepspeedai#42 15.84 from .zenflow_torch_adam import ZenFlowSelectiveAdamW deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/ops/adam/zenflow_torch_adam.py", line 685, in <module> deepspeedai#42 15.84 @_disable_dynamo_if_unsupported(single_tensor_fn=_single_tensor_adamw) deepspeedai#42 15.84 NameError: name '_disable_dynamo_if_unsupported' is not defined deepspeedai#42 15.84 [WARNING] ZenFlow disabled: torch internal optimizer symbols could not be imported: cannot import name '_disable_dynamo_if_unsupported' from 'torch.optim.optimizer' (/usr/local/lib/python3.10/dist-packages/torch/optim/optimizer.py) ``` --------- Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: Flakes342 <[email protected]>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
`_disable_dynamo_if_unsupported` fallback wasn't getting created under certain conditions. This PR is fixing this. Also removed debug print. Fixes issue installing deepspeed on torch 2.4 and 2.1 that triggered this: ``` deepspeedai#42 15.84 Traceback (most recent call last): deepspeedai#42 15.84 File "<string>", line 2, in <module> deepspeedai#42 15.84 File "<pip-setuptools-caller>", line 34, in <module> deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/setup.py", line 40, in <module> deepspeedai#42 15.84 from op_builder import get_default_compute_capabilities, OpBuilder deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/op_builder/__init__.py", line 18, in <module> deepspeedai#42 15.84 import deepspeed.ops.op_builder # noqa: F401 # type: ignore deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/__init__.py", line 25, in <module> deepspeedai#42 15.84 from . import ops deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/ops/__init__.py", line 6, in <module> deepspeedai#42 15.84 from . import adam deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/ops/adam/__init__.py", line 9, in <module> deepspeedai#42 15.84 from .zenflow_torch_adam import ZenFlowSelectiveAdamW deepspeedai#42 15.84 File "/tmp/pip-install-qgzd6ybt/deepspeed_b3b4858a062d49c7b8d6ef31332a96cf/deepspeed/ops/adam/zenflow_torch_adam.py", line 685, in <module> deepspeedai#42 15.84 @_disable_dynamo_if_unsupported(single_tensor_fn=_single_tensor_adamw) deepspeedai#42 15.84 NameError: name '_disable_dynamo_if_unsupported' is not defined deepspeedai#42 15.84 [WARNING] ZenFlow disabled: torch internal optimizer symbols could not be imported: cannot import name '_disable_dynamo_if_unsupported' from 'torch.optim.optimizer' (/usr/local/lib/python3.10/dist-packages/torch/optim/optimizer.py) ``` --------- Signed-off-by: Stas Bekman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_disable_dynamo_if_unsupportedfallback wasn't getting created under certain conditions. This PR is fixing this. Also removed debug print.Fixes issue installing deepspeed on torch 2.4 and 2.1 that triggered this: