Skip to content

Remove additional unused tests (human-eval) #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loadams merged 3 commits into from
Jul 24, 2025
Merged

Remove additional unused tests (human-eval) #7445

loadams merged 3 commits into from
Jul 24, 2025

Conversation

@loadams
Copy link
Collaborator

@loadams loadams commented Jul 23, 2025

No description provided.

@loadams loadams requested review from tjruwase and tohtana as code owners July 23, 2025 19:45
@loadams loadams requested a review from stas00 July 23, 2025 19:46
@stas00
Copy link
Collaborator

stas00 commented Jul 24, 2025

Logan, I don't know who/why those were added in the first place to know if they are ok to remove, so perhaps blame to find who to tag?

If we don't have that info I'm OK to remove those... but best to ask first?

@loadams
Copy link
Collaborator Author

loadams commented Jul 24, 2025

Logan, I don't know who/why those were added in the first place to know if they are ok to remove, so perhaps blame to find who to tag?

If we don't have that info I'm OK to remove those... but best to ask first?

@stas00 - this was added by @lekurile originally but we never got it working all the way. I'll follow up with him on this.

stas00
stas00 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will approve then and you can quickly merge if the author is in agreement.

Thank you for checking, Logan.

@loadams loadams merged commit 43f00ba into master Jul 24, 2025
9 checks passed
@loadams loadams deleted the loadams/remove-additional-unused-tests branch July 24, 2025 20:16
@loadams
Copy link
Collaborator Author

loadams commented Jul 24, 2025

Sure, I will approve then and you can quickly merge if the author is in agreement.

Thank you for checking, Logan.

@stas00 - checked with Lev and this was good to be merged, the examples in DSE should stay: https://github.com/deepspeedai/DeepSpeedExamples/tree/master/evaluation/inference/human_eval

lpnpcs pushed a commit to lpnpcs/DeepSpeed that referenced this pull request Jul 30, 2025
@loadams @lpnpcs
Remove additional unused tests (human-eval) (deepspeedai#7445)
66998dd
LYMDLUT pushed a commit to LYMDLUT/DeepSpeed that referenced this pull request Aug 20, 2025
@loadams @LYM-fire
Remove additional unused tests (human-eval) (deepspeedai#7445)
85d5efd 
Signed-off-by: lym <[email protected]>
mauryaavinash95 pushed a commit to DataStates/DeepSpeed that referenced this pull request Oct 4, 2025
@loadams
Remove additional unused tests (human-eval) (deepspeedai#7445)
fbebd6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stas00 stas00 stas00 approved these changes

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

@tohtana tohtana Awaiting requested review from tohtana tohtana is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loadams @stas00