Use past_key_value when provided #7428
Merged
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KV cache can be passed via `layer_past` or `past_key_value` arguments. Previously, `past_key_value` was ignored, causing workload incompatibilities. This PR fixes the issue while preserving the original logic. Signed-off-by: Max Kovalenko <[email protected]>
Signed-off-by: Max Kovalenko <[email protected]>
Contributor
Author
|
While reviewing this change, we also noted a possible existing bug, such that Should it be a separate PR maybe? |
sfc-gh-truwase
approved these changes
Jul 14, 2025
Collaborator
Thanks for providing this fix.
Yes, it would be better as a separate PR. |
lpnpcs
pushed a commit
to lpnpcs/DeepSpeed
that referenced
this pull request
Jul 30, 2025
The KV cache can be passed via `layer_past` or `past_key_value` arguments. Previously, `past_key_value` was ignored, causing workload incompatibilities. This PR fixes the issue while preserving the original logic. --------- Signed-off-by: Max Kovalenko <[email protected]>
LYMDLUT
pushed a commit
to LYMDLUT/DeepSpeed
that referenced
this pull request
Aug 20, 2025
The KV cache can be passed via `layer_past` or `past_key_value` arguments. Previously, `past_key_value` was ignored, causing workload incompatibilities. This PR fixes the issue while preserving the original logic. --------- Signed-off-by: Max Kovalenko <[email protected]> Signed-off-by: lym <[email protected]>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
The KV cache can be passed via `layer_past` or `past_key_value` arguments. Previously, `past_key_value` was ignored, causing workload incompatibilities. This PR fixes the issue while preserving the original logic. --------- Signed-off-by: Max Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KV cache can be passed via
layer_pastorpast_key_valuearguments. Previously,past_key_valuewas ignored, causing workload incompatibilities.This PR fixes the issue while preserving the original logic.