Add getter APIs for TP/PP/DP ranks in DeepSpeedEngine #7427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosungMyung
force-pushed
the
feature/add-parallel-rank-api
branch
from
5df4bcc to
718fb78
Compare
Signed-off-by: WoosungMyung <[email protected]>
WoosungMyung
force-pushed
the
feature/add-parallel-rank-api
branch
from
718fb78 to
cc89694
Compare
WoosungMyung
force-pushed
the
feature/add-parallel-rank-api
branch
from
2ba0c78 to
726c30e
Compare
Signed-off-by: WoosungMyung <[email protected]>
WoosungMyung
force-pushed
the
feature/add-parallel-rank-api
branch
from
c4b8193 to
6c8e092
Compare
sfc-gh-truwase
approved these changes
Aug 1, 2025
Contributor
Author
|
@sfc-gh-truwase |
Collaborator
|
@delock can you please help with the xpu CI? Thanks! |
Collaborator
I've also reached out to @Liangliang-Ma on this as well. The test is currently skipped on this PR so it should merge now. |
loadams
approved these changes
Aug 1, 2025
Contributor
Author
|
Thanks a lot for merging the previous PR! I really appreciate the review and guidance throughout the process! |
LYMDLUT
pushed a commit
to LYMDLUT/DeepSpeed
that referenced
this pull request
Aug 20, 2025
Thanks again for giving opportunity for improving this Community! This PR is from Issue deepspeedai#7423. 1) Motivation To improve compatibility with low-level profiling tools (e.g., NVIDIA CUPTI or DCGM), it can be useful to expose parallelism-specific rank (tensor/pipeline/data) at the engine level. 2) Changes I Added three getter methods to DeepSpeedEngine: - get_tensor_parallel_rank() - get_pipeline_parallel_rank() - get_data_parallel_rank() Thank you for reviewing this contribution! --------- Signed-off-by: WoosungMyung <[email protected]> Co-authored-by: Logan Adams <[email protected]> Signed-off-by: lym <[email protected]>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
Thanks again for giving opportunity for improving this Community! This PR is from Issue deepspeedai#7423. 1) Motivation To improve compatibility with low-level profiling tools (e.g., NVIDIA CUPTI or DCGM), it can be useful to expose parallelism-specific rank (tensor/pipeline/data) at the engine level. 2) Changes I Added three getter methods to DeepSpeedEngine: - get_tensor_parallel_rank() - get_pipeline_parallel_rank() - get_data_parallel_rank() Thank you for reviewing this contribution! --------- Signed-off-by: WoosungMyung <[email protected]> Co-authored-by: Logan Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks again for giving opportunity for improving this Community!
This PR is from Issue #7423.
To improve compatibility with low-level profiling tools (e.g., NVIDIA CUPTI or DCGM), it can be useful to expose parallelism-specific rank (tensor/pipeline/data) at the engine level.
I Added three getter methods to DeepSpeedEngine:
Thank you for reviewing this contribution!