Skip to content

Conversation

@stas00
Copy link
Collaborator

@stas00 stas00 commented Jul 10, 2025

trying a day old accelerate from the day before huggingface/accelerate@1ac8643

@stas00 stas00 requested a review from loadams as a code owner July 10, 2025 05:29
@stas00
Copy link
Collaborator Author

stas00 commented Jul 10, 2025

I diffed the installed package lists for good/bad and I can now repro, the problem comes from the just released datasets==4.0.0 which is the source of this breakage.

if someone needs this to work right away, force datasets==3.6.0

@stas00
Copy link
Collaborator Author

stas00 commented Jul 10, 2025

So it's comparing:

def simple_accuracy(preds, labels):
    print(preds, labels)
    print(f"{preds==labels}")
    return float((preds == labels).mean())

data:

Column([1, 0, 0, 1, 1]) Column([1, 0, 0, 1, 0])
False

and fails there as it returns a bool, and bool has no mean

@stas00
Copy link
Collaborator Author

stas00 commented Jul 10, 2025

reported it here huggingface/datasets#7679 and huggingface/accelerate#3676

@stas00
Copy link
Collaborator Author

stas00 commented Jul 10, 2025

so we can merge the workaround to force datasets==3.6.0 in this PR until upstream fixes it.

stas00 and others added 2 commits July 10, 2025 15:01
@stas00
Copy link
Collaborator Author

stas00 commented Jul 10, 2025

update: they are working on fixing the evaluate package.

@sfc-gh-truwase sfc-gh-truwase merged commit affee60 into master Jul 11, 2025
9 checks passed
@sfc-gh-truwase sfc-gh-truwase deleted the stas00-patch-1 branch July 11, 2025 14:07
lpnpcs pushed a commit to lpnpcs/DeepSpeed that referenced this pull request Jul 30, 2025
trying a day old accelerate from the day before
huggingface/accelerate@1ac8643

---------

Signed-off-by: Stas Bekman <[email protected]>
LYMDLUT pushed a commit to LYMDLUT/DeepSpeed that referenced this pull request Aug 20, 2025
trying a day old accelerate from the day before
huggingface/accelerate@1ac8643

---------

Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: lym <[email protected]>
mauryaavinash95 pushed a commit to DataStates/DeepSpeed that referenced this pull request Oct 4, 2025
trying a day old accelerate from the day before
huggingface/accelerate@1ac8643

---------

Signed-off-by: Stas Bekman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants