[BUGFIX] Reset bucket.elements after reduction in ZeRO Stage 3
#7418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohtana
approved these changes
Jul 8, 2025
Collaborator
tohtana
left a comment
tohtana
left a comment
There was a problem hiding this comment.
@rahul713rk Thank you for the fix!
lpnpcs
pushed a commit
to lpnpcs/DeepSpeed
that referenced
this pull request
Jul 30, 2025
…pspeedai#7418) closes deepspeedai#7415 # Description Resets `bucket.elements` after reduction in ZeRO Stage 3. Without this, the bucket grows indefinitely, reducing only one param at a time. Added `bucket.elements = 0` after `params_in_bucket.clear()`. Co-authored-by: a <a>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
…pspeedai#7418) closes deepspeedai#7415 # Description Resets `bucket.elements` after reduction in ZeRO Stage 3. Without this, the bucket grows indefinitely, reducing only one param at a time. Added `bucket.elements = 0` after `params_in_bucket.clear()`. Co-authored-by: a <a>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7415
Description
Resets
bucket.elementsafter reduction in ZeRO Stage 3.Without this, the bucket grows indefinitely, reducing only one param at a time.
Added
bucket.elements = 0afterparams_in_bucket.clear().