fix: DeepCompile for torch 2.8 #7402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In torch v2.8.0, all symm mem code are moved into a dedicated folder pytorch/pytorch@ffc6cbf So this PR tries to address this change by checking if we have it located under `torch/csrc/distributed/c10d/symm_mem/SymmetricMemory.hpp` (new location). If not, we fall back to the original place for backward compatibilities. This PR also clean up some includes in `z1/2/3.cpp` that has already been included in `deepcompile.h` Signed-off-by: Hollow Man <[email protected]>
Collaborator
|
Looks good to me. Thank you for your contribution, @HollowMan6! |
tohtana
approved these changes
Jun 30, 2025
lpnpcs
pushed a commit
to lpnpcs/DeepSpeed
that referenced
this pull request
Jul 30, 2025
In torch v2.8.0, all symm mem code are moved into a dedicated folder pytorch/pytorch@ffc6cbf So this PR tries to address this change by checking if we have it located under `torch/csrc/distributed/c10d/symm_mem/SymmetricMemory.hpp` (new location). If not, we fall back to the original place for backward compatibilities. This PR also clean up some includes in `z1/2/3.cpp` that has already been included in `deepcompile.h` Signed-off-by: Hollow Man <[email protected]>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
In torch v2.8.0, all symm mem code are moved into a dedicated folder pytorch/pytorch@ffc6cbf So this PR tries to address this change by checking if we have it located under `torch/csrc/distributed/c10d/symm_mem/SymmetricMemory.hpp` (new location). If not, we fall back to the original place for backward compatibilities. This PR also clean up some includes in `z1/2/3.cpp` that has already been included in `deepcompile.h` Signed-off-by: Hollow Man <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In torch v2.8.0, all symm mem code are moved into a dedicated folder pytorch/pytorch@ffc6cbf
So this PR tries to address this change by checking if we have it located under
torch/csrc/distributed/c10d/symm_mem/SymmetricMemory.hpp(new location). If not, we fall back to the original place for backward compatibilities.This PR also clean up some includes in
z1/2/3.cppthat has already been included indeepcompile.h