Fix dtype mismatch in TestParamPartitioningSkipInit
#7377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Tanaka <[email protected]>
Signed-off-by: Masahiro Tanaka <[email protected]>
loadams
approved these changes
Jun 23, 2025
Antlera
pushed a commit
to Antlera/DeepSpeed
that referenced
this pull request
Jun 27, 2025
`TestParamPartitioningSkipInit` throws the following error. ``` ====================================== short test summary info ====================================== FAILED test_zero.py::TestParamPartitioningSkipInit::test[dtype1] - RuntimeError: mat1 and mat2 must have the same dtype, but got Half and BFloat16 ========= 1 failed, 204 passed, 66 skipped, 15 deselected, 5 warnings in 2305.03s (0:38:25) ========= ``` The test always sets the model's dtype to `torch.bfloat16` and ignores the test parameter `dtype` when bfloat16 is supported. This causes a dtype mismatch when `dtype=torch.float16` is given as the test parameter because the data loader respects the test parameter dtype. --------- Signed-off-by: Masahiro Tanaka <[email protected]> Co-authored-by: Logan Adams <[email protected]>
lpnpcs
pushed a commit
to lpnpcs/DeepSpeed
that referenced
this pull request
Jul 30, 2025
`TestParamPartitioningSkipInit` throws the following error. ``` ====================================== short test summary info ====================================== FAILED test_zero.py::TestParamPartitioningSkipInit::test[dtype1] - RuntimeError: mat1 and mat2 must have the same dtype, but got Half and BFloat16 ========= 1 failed, 204 passed, 66 skipped, 15 deselected, 5 warnings in 2305.03s (0:38:25) ========= ``` The test always sets the model's dtype to `torch.bfloat16` and ignores the test parameter `dtype` when bfloat16 is supported. This causes a dtype mismatch when `dtype=torch.float16` is given as the test parameter because the data loader respects the test parameter dtype. --------- Signed-off-by: Masahiro Tanaka <[email protected]> Co-authored-by: Logan Adams <[email protected]>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
`TestParamPartitioningSkipInit` throws the following error. ``` ====================================== short test summary info ====================================== FAILED test_zero.py::TestParamPartitioningSkipInit::test[dtype1] - RuntimeError: mat1 and mat2 must have the same dtype, but got Half and BFloat16 ========= 1 failed, 204 passed, 66 skipped, 15 deselected, 5 warnings in 2305.03s (0:38:25) ========= ``` The test always sets the model's dtype to `torch.bfloat16` and ignores the test parameter `dtype` when bfloat16 is supported. This causes a dtype mismatch when `dtype=torch.float16` is given as the test parameter because the data loader respects the test parameter dtype. --------- Signed-off-by: Masahiro Tanaka <[email protected]> Co-authored-by: Logan Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestParamPartitioningSkipInitthrows the following error.The test always sets the model's dtype to
torch.bfloat16and ignores the test parameterdtypewhen bfloat16 is supported. This causes a dtype mismatch whendtype=torch.float16is given as the test parameter because the data loader respects the test parameter dtype.