Relax tolerances for FP8 unit test only for ROCm + FP16 #7373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
approved these changes
Jun 20, 2025
Antlera
pushed a commit
to Antlera/DeepSpeed
that referenced
this pull request
Jun 27, 2025
…7373) Relaxing the tolerance values to enable the below unit test, with FP16 data type on ROCm `unit/runtime/half_precision/test_fp8.py::TestFp8ComposabilityAcrossZero::test[fp16] ` ``` # Relax tolerance only for ROCm + FP16 if is_rocm_pytorch() and model_dtype == torch.float16: rtol, atol = 3e-07, 3e-05 ``` cc: @jithunnair-amd
lpnpcs
pushed a commit
to lpnpcs/DeepSpeed
that referenced
this pull request
Jul 30, 2025
…7373) Relaxing the tolerance values to enable the below unit test, with FP16 data type on ROCm `unit/runtime/half_precision/test_fp8.py::TestFp8ComposabilityAcrossZero::test[fp16] ` ``` # Relax tolerance only for ROCm + FP16 if is_rocm_pytorch() and model_dtype == torch.float16: rtol, atol = 3e-07, 3e-05 ``` cc: @jithunnair-amd
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
…7373) Relaxing the tolerance values to enable the below unit test, with FP16 data type on ROCm `unit/runtime/half_precision/test_fp8.py::TestFp8ComposabilityAcrossZero::test[fp16] ` ``` # Relax tolerance only for ROCm + FP16 if is_rocm_pytorch() and model_dtype == torch.float16: rtol, atol = 3e-07, 3e-05 ``` cc: @jithunnair-amd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxing the tolerance values to enable the below unit test, with FP16 data type on ROCm
unit/runtime/half_precision/test_fp8.py::TestFp8ComposabilityAcrossZero::test[fp16]cc: @jithunnair-amd