fix keep_module_on_host #7112
Merged
fix keep_module_on_host #7112
+59
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: inkcherry <[email protected]>
Signed-off-by: inkcherry <[email protected]>
Signed-off-by: inkcherry <[email protected]>
inkcherry
force-pushed
the
fix_keep_module_on_host
branch
from
215ea7d to
4bc63f4
Compare
oelayan7
reviewed
Mar 6, 2025
deepspeed/module_inject/auto_tp.py
Outdated
| self.orig_layer_impl = orig_layer_impl | ||
| self.linear_policies = None | ||
| self.conv_linear_layer = False | ||
| self.keep_module_on_host = keep_module_on_host |
Contributor
There was a problem hiding this comment.
self.keep_module_on_host can be deleted, as it won't be used anywhere.
You can simply pass keep_module_on_host without saving it.
deepspeed/module_inject/auto_tp.py
Outdated
| self.linear_policies = None | ||
| self.conv_linear_layer = False | ||
| self.keep_module_on_host = keep_module_on_host | ||
| TensorParallel_Layer.set_keep_module_on_host(self.keep_module_on_host) |
Contributor
There was a problem hiding this comment.
TensorParallel_Layer.set_keep_module_on_host(keep_module_on_host)
Signed-off-by: inkcherry <[email protected]>
Contributor
|
LGTM |
tjruwase
approved these changes
Mar 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
inkcherry
added a commit
to inkcherry/DeepSpeed
that referenced
this pull request
Mar 13, 2025
Reapply deepspeedai#6846. FYI @oelayan7 --------- Signed-off-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Signed-off-by: inkcherry <[email protected]>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Mar 20, 2025
Reapply deepspeedai#6846. FYI @oelayan7 --------- Signed-off-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]>
loadams
added a commit
that referenced
this pull request
Mar 25, 2025
Reapply #6846. FYI @oelayan7 --------- Signed-off-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Signed-off-by: Logan Adams <[email protected]>
ys950902
pushed a commit
to ys950902/DeepSpeed
that referenced
this pull request
May 21, 2025
Reapply deepspeedai#6846. FYI @oelayan7 --------- Signed-off-by: inkcherry <[email protected]> Co-authored-by: Logan Adams <[email protected]> Signed-off-by: yisheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #6846.
FYI @oelayan7