Skip to content

Conversation

@stas00
Copy link
Collaborator

@stas00 stas00 commented Mar 14, 2023

Checkpoint pytorch_model is begin to save!

is not quite English. Trying to make it more readable.

@stas00 stas00 requested review from jeffra and tjruwase as code owners March 14, 2023 21:02
@tjruwase tjruwase merged commit e355863 into deepspeedai:master Mar 14, 2023
@stas00 stas00 deleted the patch-3 branch March 14, 2023 22:43
@jukofyork
Copy link

Somewhere his merge got reverted and it's back to saying the same again:

        log_dist(f"[Torch] Checkpoint {info.tag} is begin to save!", ranks=[0])

https://github.com/deepspeedai/DeepSpeed/blob/902e78c989383dac09d47325f39b5c83d5e7f889/deepspeed/runtime/checkpoint_engine/torch_checkpoint_engine.py#L27C1-L27C80

@stas00
Copy link
Collaborator Author

stas00 commented Sep 2, 2025

you're correct, let's replay it

stas00 added a commit that referenced this pull request Sep 2, 2025
replay #3019 as it got reverted
@stas00 stas00 mentioned this pull request Sep 2, 2025
@stas00
Copy link
Collaborator Author

stas00 commented Sep 2, 2025

#7536

stas00 added a commit that referenced this pull request Sep 2, 2025
replay #3019 as it got
reverted
@stas00
Copy link
Collaborator Author

stas00 commented Sep 2, 2025

the replay has been merged, thank you for reporting @jukofyork

tohtana pushed a commit that referenced this pull request Sep 3, 2025
replay #3019 as it got
reverted

Signed-off-by: Masahiro Tanaka <[email protected]>
Flakes342 pushed a commit to Flakes342/DeepSpeed that referenced this pull request Sep 9, 2025
replay deepspeedai#3019 as it got
reverted

Signed-off-by: Flakes342 <[email protected]>
mauryaavinash95 pushed a commit to DataStates/DeepSpeed that referenced this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants