Repository navigation
fix: keep the detected MIME type when FileTypeRouter attaches meta - #13419
Merged
anakin87 merged 3 commits intoOct 27, 2026
Merged
Conversation
Contributor
|
@mittalpk is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
3 tasks done
anakin87
approved these changes
Oct 27, 2026
anakin87
left a comment
anakin87
left a comment
Member
There was a problem hiding this comment.
Thank you!
I pushed a few simplifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
When
metais passed,FileTypeRouterreads a path into aByteStreamso the metadata can be attached, but thatByteStreamhadmime_type=Noneeven though the router had just detected the type. Downstream converters such asFileToFileContentthen could not tell its type. The copy now carries the detected MIME type, and aByteStreamsource keeps its own.How did you test it?
Added
test_run_with_meta_keeps_detected_mime_type_on_paths(fails without the fix) andtest_run_with_meta_keeps_bytestream_mime_type. Router and converter-utils tests: 223 passed.Notes for the reviewer
One-line change in
FileTypeRouter.run, plus a release note.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.