Skip to content

fix: reject NaN/inf weights in DocumentJoiner - #13410

Merged
davidsbatista merged 2 commits into
deepset-ai:mainfrom
pei711:contrib/document-joiner-reject-nonfinite-weights
Nov 5, 2026
Merged

fix: reject NaN/inf weights in DocumentJoiner#13410
davidsbatista merged 2 commits into
deepset-ai:mainfrom
pei711:contrib/document-joiner-reject-nonfinite-weights

Conversation

@pei711

@pei711 pei711 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

DocumentJoiner only rejected negative weights. NaN passed the check and poisoned score normalization; inf slipped through too. Now validates with math.isfinite. Error message keeps 'must not be negative' phrasing for existing tests.

@pei711
pei711 requested a review from a team as a code owner October 23, 2026 14:57
@pei711
pei711 requested review from davidsbatista and removed request for a team October 23, 2026 14:57
@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

@pei711 is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@HaystackBot

HaystackBot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Hi @pei711, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from davidsbatista October 23, 2026 16:33
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Oct 23, 2026
@HaystackBot
HaystackBot marked this pull request as draft October 23, 2026 16:34
@CLAassistant

CLAassistant commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@HaystackBot

HaystackBot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Hi @pei711, just a friendly reminder: this PR is still in draft because the Contributor License Agreement (CLA) hasn't been signed yet. We'd love to review your contribution! Please sign the CLA via the link in the license/cla check, and this PR will automatically be marked ready for review.

@HaystackBot

HaystackBot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Hi @pei711, this PR is still waiting for the Contributor License Agreement (CLA) to be signed. Please note that if the CLA isn't signed within the next 4 days, this PR will be automatically closed as stale. Signing only takes a minute via the link in the license/cla check, and the PR will then automatically be marked ready for review.

@HaystackBot
HaystackBot marked this pull request as ready for review November 5, 2026 08:28
@HaystackBot HaystackBot removed the cla-pending PR is in draft until the contributor signs the CLA label Nov 5, 2026
@HaystackBot

HaystackBot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for signing the CLA, @pei711! 🎉 This PR is now ready for review again and the reviewer has been re-assigned.

@vercel

vercel Bot commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
haystack-docs Ignored Ignored Preview Nov 5, 2026 1:48pm UTC

Request Review

davidsbatista
davidsbatista approved these changes Nov 5, 2026
View reviewed changes

@davidsbatista davidsbatista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@davidsbatista
davidsbatista enabled auto-merge (squash) November 5, 2026 13:49
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Nov 5, 2026
@davidsbatista
davidsbatista merged commit d9c7197 into deepset-ai:main Nov 5, 2026
24 checks passed
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  haystack/components/joiners
  document_joiner.py
Project Total  

This report was generated by python-coverage-comment-action

This was referenced Nov 6, 2026
Closed
Merged
@simin-yuan simin-yuan mentioned this pull request Nov 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees

No one assigned

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pei711 @HaystackBot @CLAassistant @davidsbatista