Skip to content

test: adding Mixin filter async tests and using them in InMemoryDocumentStore tests#10975

Merged
davidsbatista merged 1 commit intomainfrom
tests/add-filter-async-mixin-tests
Mar 30, 2026
Merged

test: adding Mixin filter async tests and using them in InMemoryDocumentStore tests#10975
davidsbatista merged 1 commit intomainfrom
tests/add-filter-async-mixin-tests

Conversation

@davidsbatista
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista commented Mar 30, 2026

Related Issues

Proposed Changes:

A new class FilterDocumentsAsyncTest with 3 tests:

  • test_no_filters_async: Verifies the async path returns all docs with no filter
  • test_filter_simple_async: One equality filter — confirms async plumbing works with a filter
  • test_filter_compound_async: One AND filter — verifies compound filters aren't broken by the async path
  • InMemoryDocumenStore imports the class to test async calls to filter

How did you test it?

  • unit tests, integration tests, manual verification, instructions for manual tests

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Mar 30, 2026 7:58am

Request Review

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Mar 30, 2026
@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 30, 2026
@davidsbatista davidsbatista marked this pull request as ready for review March 30, 2026 08:00
@davidsbatista davidsbatista requested a review from a team as a code owner March 30, 2026 08:00
@davidsbatista davidsbatista requested review from bogdankostic and removed request for a team March 30, 2026 08:00
@anakin87 anakin87 modified the milestone: 2.27.0 Mar 30, 2026
@davidsbatista davidsbatista merged commit b02b7ce into main Mar 30, 2026
27 of 28 checks passed
@davidsbatista davidsbatista deleted the tests/add-filter-async-mixin-tests branch March 30, 2026 09:47
SyedShahmeerAli12 pushed a commit to SyedShahmeerAli12/haystack that referenced this pull request Mar 30, 2026
@davidsbatista @SyedShahmeerAli12
test: adding mixing filter async tests + implementing them in InMemor…
276d93e 
…yDocumentStore tests (deepset-ai#10975)
anakin87 added a commit that referenced this pull request Mar 30, 2026
@SyedShahmeerAli12 @anakin87
@pandego @davidsbatista @HaystackBot @satishkc7 @julian-risch @claude
docs: add TavilyWebSearch component page and external integration en…
93a986b 
…try (#10954)

* docs: add TavilyWebSearch component page and external integration entry

* fix: `CountDocumentsAsyncTest`, `WriteDocumentsAsyncTest`, `WriteDocumentsAsyncTest` (#10948)

* fix: address #10917

* removing lazyimport + solving MRO conflict

---------

Co-authored-by: David S. Batista <[email protected]>

* docs: remove gpt-3.5-turbo mentions and use ChatMessage.txt (no content) (#10958)

* fix: `DeleteAllAsyncTest`, `DeleteByFilterAsyncTest`, (#10952)

* fix: address #10919

* adding delete_all_documents_async missing in InMemoryDocumentStore

---------

Co-authored-by: David S. Batista <[email protected]>

* Sync Haystack API reference on Docusaurus (#10959)

Co-authored-by: davidsbatista <[email protected]>

* fix: `UpdateByFilterAsyncTest`, `CountDocumentsByFilterAsyncTest`, `CountUniqueMetadataByFilterAsyncTest` (#10953)

* fix: address #10920

* formatting

---------

Co-authored-by: David S. Batista <[email protected]>

* Sync Haystack API reference on Docusaurus (#10961)

Co-authored-by: davidsbatista <[email protected]>

* docs: fixing code snippets syntax errors (#10955)

* fixing docs syntax errors

* fixing a few more docs syntax errors

* feat: add get_meta_data async mixin tests to haystack.testing + InMemoryDocumentStore async operations and tests (#10963)

* adding get_metadata async related Mixin tests

* adding get_metadata async methods to the InMemoryDocumentStore

* using Mixin async metadata tests to InMemoryDocumentstore tests

* adding release notes

* double ticks in release notes

* Update haystack/testing/document_store_async.py

Co-authored-by: Stefano Fiorucci <[email protected]>

---------

Co-authored-by: Stefano Fiorucci <[email protected]>

* Sync Haystack API reference on Docusaurus (#10962)

Co-authored-by: davidsbatista <[email protected]>

* docs: update llama.cpp repo links from ggerganov to ggml-org (#10964)

* Sync Core Integrations API reference (nvidia) on Docusaurus (#10974)

Co-authored-by: anakin87 <[email protected]>

* build: switch to trusted publishing (#10976)

* test: adding mixing filter async tests + implementing them in InMemoryDocumentStore tests (#10975)

* docs: address reviewer feedback on TavilyWebSearch docs

- Fix pipeline position description (remove LinkContentFetcher reference)
- Remove hardcoded model name to avoid future maintenance
- Fix .content -> .text (field was removed)
- Move Tavily entry from external-integrations-websearch.mdx to websearch.mdx
- Copy tavilywebsearch.mdx to versioned_docs/version-2.26
- Add tavilywebsearch to sidebars.js and version-2.26-sidebars.json

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

---------

Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Miguel Miranda Dias <[email protected]>
Co-authored-by: David S. Batista <[email protected]>
Co-authored-by: Haystack Bot <[email protected]>
Co-authored-by: davidsbatista <[email protected]>
Co-authored-by: SATISH K C <[email protected]>
Co-authored-by: anakin87 <[email protected]>
Co-authored-by: Julian Risch <[email protected]>
Co-authored-by: Claude Sonnet 4.6 <[email protected]>
SyedShahmeerAli12 added a commit to SyedShahmeerAli12/haystack-core-integrations that referenced this pull request Mar 30, 2026
@SyedShahmeerAli12 @claude
refactor(valkey): use async DocumentStore mixin tests
8148cba 
Inherit from async mixin classes introduced in deepset-ai/haystack#10975
to eliminate duplicate test code in TestValkeyDocumentStoreAsync.

Mixins added (from haystack.testing.document_store and document_store_async):
- CountDocumentsAsyncTest
- WriteDocumentsAsyncTest
- DeleteDocumentsAsyncTest
- DeleteAllAsyncTest
- DeleteByFilterAsyncTest
- UpdateByFilterAsyncTest
- CountDocumentsByFilterAsyncTest
- CountUniqueMetadataByFilterAsyncTest
- GetMetadataFieldMinMaxAsyncTest
- GetMetadataFieldUniqueValuesAsyncTest

Override WriteDocumentsAsyncTest methods that rely on DuplicatePolicy.FAIL
and DuplicatePolicy.SKIP, which are not supported by ValkeyDocumentStore.

Closes deepset-ai#3053

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@SyedShahmeerAli12 SyedShahmeerAli12 mentioned this pull request Mar 30, 2026
Open
SyedShahmeerAli12 added a commit to SyedShahmeerAli12/haystack-core-integrations that referenced this pull request Mar 31, 2026
@SyedShahmeerAli12 @claude
fix(valkey): bump haystack-ai to >=2.27.0rc1
9530882 
The async test mixin classes (document_store_async module) were added
in deepset-ai/haystack#10975 and are only available from haystack-ai>=2.27.0rc1.
The previous constraint (>=2.26.1) caused a ModuleNotFoundError at test collection.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
SyedShahmeerAli12 added a commit to SyedShahmeerAli12/haystack-core-integrations that referenced this pull request Apr 1, 2026
@SyedShahmeerAli12 @claude
refactor(valkey): use async DocumentStore mixin tests
d3f2b74 
Inherit from async mixin classes introduced in deepset-ai/haystack#10975
to eliminate duplicate test code in TestValkeyDocumentStoreAsync.

Mixins added (from haystack.testing.document_store and document_store_async):
- CountDocumentsAsyncTest
- WriteDocumentsAsyncTest
- DeleteDocumentsAsyncTest
- DeleteAllAsyncTest
- DeleteByFilterAsyncTest
- UpdateByFilterAsyncTest
- CountDocumentsByFilterAsyncTest
- CountUniqueMetadataByFilterAsyncTest
- GetMetadataFieldMinMaxAsyncTest
- GetMetadataFieldUniqueValuesAsyncTest

Override WriteDocumentsAsyncTest methods that rely on DuplicatePolicy.FAIL
and DuplicatePolicy.SKIP, which are not supported by ValkeyDocumentStore.

Closes deepset-ai#3053

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
SyedShahmeerAli12 added a commit to SyedShahmeerAli12/haystack-core-integrations that referenced this pull request Apr 1, 2026
@SyedShahmeerAli12 @claude
fix(valkey): bump haystack-ai to >=2.27.0rc1
871c774 
The async test mixin classes (document_store_async module) were added
in deepset-ai/haystack#10975 and are only available from haystack-ai>=2.27.0rc1.
The previous constraint (>=2.26.1) caused a ModuleNotFoundError at test collection.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
SyedShahmeerAli12 added a commit to SyedShahmeerAli12/haystack-core-integrations that referenced this pull request Apr 1, 2026
@SyedShahmeerAli12
refactor(valkey): use async DocumentStore mixin tests
5bfdd00 
Inherit from async mixin classes introduced in deepset-ai/haystack#10975
to eliminate duplicate test code in TestValkeyDocumentStoreAsync.

Mixins added (from haystack.testing.document_store and document_store_async):
- CountDocumentsAsyncTest
- WriteDocumentsAsyncTest
- DeleteDocumentsAsyncTest
- DeleteAllAsyncTest
- DeleteByFilterAsyncTest
- UpdateByFilterAsyncTest
- CountDocumentsByFilterAsyncTest
- CountUniqueMetadataByFilterAsyncTest
- GetMetadataFieldMinMaxAsyncTest
- GetMetadataFieldUniqueValuesAsyncTest

Override WriteDocumentsAsyncTest methods that rely on DuplicatePolicy.FAIL
and DuplicatePolicy.SKIP, which are not supported by ValkeyDocumentStore.

Closes deepset-ai#3053
SyedShahmeerAli12 added a commit to SyedShahmeerAli12/haystack-core-integrations that referenced this pull request Apr 1, 2026
@SyedShahmeerAli12
fix(valkey): bump haystack-ai to >=2.27.0rc1
17cf346 
The async test mixin classes (document_store_async module) were added
in deepset-ai/haystack#10975 and are only available from haystack-ai>=2.27.0rc1.
The previous constraint (>=2.26.1) caused a ModuleNotFoundError at test collection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

Assignees

No one assigned

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A small FilterDocumentsAsyncTest with 3 smoke tests

3 participants

@davidsbatista @bogdankostic @anakin87