Skip to content

feat: add get_meta_data async mixin tests to haystack.testing + InMemoryDocumentStore async operations and tests#10963

Merged
davidsbatista merged 6 commits intomainfrom
feat/add-getmetadata-async-mixin-tests
Mar 27, 2026
Merged

feat: add get_meta_data async mixin tests to haystack.testing + InMemoryDocumentStore async operations and tests#10963
davidsbatista merged 6 commits intomainfrom
feat/add-getmetadata-async-mixin-tests

Conversation

@davidsbatista
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista commented Mar 27, 2026

Related Issues

Proposed Changes:

  • adding async Mixin tests for the document store metadata related operations
  • adding new async methods to the InMemoryDocumentStore
    • get_metadata_fields_info_async()
    • get_metadata_field_min_max_async()
    • get_metadata_field_unique_values_async()
  • relying on the async Mixin to cover the InMemoryDocumentStore tests

How did you test it?

  • unit tests, integration tests + CI

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Mar 27, 2026 4:36pm

Request Review

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Mar 27, 2026
@davidsbatista davidsbatista changed the title Feat/add getmetadata async mixin tests feat: add get_meta_data async mixin tests to haystack.testing + InMemoryDocumentStore async operations and tests Mar 27, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 27, 2026

Pull Request Test Coverage Report for Build 23656991764

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 92.899%

Files with Coverage Reduction New Missed Lines %
document_stores/in_memory/document_store.py 1 94.88%
Totals Coverage Status
Change from base Build 23655555964: 0.002%
Covered Lines: 15870
Relevant Lines: 17083

💛 - Coveralls

@davidsbatista davidsbatista marked this pull request as ready for review March 27, 2026 16:26
@davidsbatista davidsbatista requested a review from a team as a code owner March 27, 2026 16:26
@davidsbatista davidsbatista requested review from anakin87 and removed request for a team March 27, 2026 16:26
Copy link
Copy Markdown
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion to make Ruff happy

@davidsbatista davidsbatista enabled auto-merge (squash) March 27, 2026 16:39
@davidsbatista davidsbatista merged commit 23c25d4 into main Mar 27, 2026
22 checks passed
@davidsbatista davidsbatista deleted the feat/add-getmetadata-async-mixin-tests branch March 27, 2026 16:47
SyedShahmeerAli12 pushed a commit to SyedShahmeerAli12/haystack that referenced this pull request Mar 30, 2026
…oryDocumentStore async operations and tests (deepset-ai#10963)

* adding get_metadata async related Mixin tests

* adding get_metadata async methods to the InMemoryDocumentStore

* using Mixin async metadata tests to InMemoryDocumentstore tests

* adding release notes

* double ticks in release notes

* Update haystack/testing/document_store_async.py

Co-authored-by: Stefano Fiorucci <[email protected]>

---------

Co-authored-by: Stefano Fiorucci <[email protected]>
anakin87 added a commit that referenced this pull request Mar 30, 2026
…try (#10954)

* docs: add TavilyWebSearch component page and external integration entry

* fix: `CountDocumentsAsyncTest`, `WriteDocumentsAsyncTest`, `WriteDocumentsAsyncTest` (#10948)

* fix: address #10917

* removing lazyimport + solving MRO conflict

---------

Co-authored-by: David S. Batista <[email protected]>

* docs: remove gpt-3.5-turbo mentions and use ChatMessage.txt (no content) (#10958)

* fix: `DeleteAllAsyncTest`, `DeleteByFilterAsyncTest`, (#10952)

* fix: address #10919

* adding delete_all_documents_async missing in InMemoryDocumentStore

---------

Co-authored-by: David S. Batista <[email protected]>

* Sync Haystack API reference on Docusaurus (#10959)

Co-authored-by: davidsbatista <[email protected]>

* fix: `UpdateByFilterAsyncTest`, `CountDocumentsByFilterAsyncTest`, `CountUniqueMetadataByFilterAsyncTest` (#10953)

* fix: address #10920

* formatting

---------

Co-authored-by: David S. Batista <[email protected]>

* Sync Haystack API reference on Docusaurus (#10961)

Co-authored-by: davidsbatista <[email protected]>

* docs: fixing code snippets syntax errors (#10955)

* fixing docs syntax errors

* fixing a few more docs syntax errors

* feat: add get_meta_data async mixin tests to haystack.testing + InMemoryDocumentStore async operations and tests (#10963)

* adding get_metadata async related Mixin tests

* adding get_metadata async methods to the InMemoryDocumentStore

* using Mixin async metadata tests to InMemoryDocumentstore tests

* adding release notes

* double ticks in release notes

* Update haystack/testing/document_store_async.py

Co-authored-by: Stefano Fiorucci <[email protected]>

---------

Co-authored-by: Stefano Fiorucci <[email protected]>

* Sync Haystack API reference on Docusaurus (#10962)

Co-authored-by: davidsbatista <[email protected]>

* docs: update llama.cpp repo links from ggerganov to ggml-org (#10964)

* Sync Core Integrations API reference (nvidia) on Docusaurus (#10974)

Co-authored-by: anakin87 <[email protected]>

* build: switch to trusted publishing (#10976)

* test: adding mixing filter async tests + implementing them in InMemoryDocumentStore tests (#10975)

* docs: address reviewer feedback on TavilyWebSearch docs

- Fix pipeline position description (remove LinkContentFetcher reference)
- Remove hardcoded model name to avoid future maintenance
- Fix .content -> .text (field was removed)
- Move Tavily entry from external-integrations-websearch.mdx to websearch.mdx
- Copy tavilywebsearch.mdx to versioned_docs/version-2.26
- Add tavilywebsearch to sidebars.js and version-2.26-sidebars.json

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

---------

Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Miguel Miranda Dias <[email protected]>
Co-authored-by: David S. Batista <[email protected]>
Co-authored-by: Haystack Bot <[email protected]>
Co-authored-by: davidsbatista <[email protected]>
Co-authored-by: SATISH K C <[email protected]>
Co-authored-by: anakin87 <[email protected]>
Co-authored-by: Julian Risch <[email protected]>
Co-authored-by: Claude Sonnet 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetMetadataFieldsInfoAsyncTest, GetMetadataFieldMinMaxAsyncTest, GetMetadataFieldUniqueValuesAsyncTest

3 participants