test: add delete_all_documents, delete_by_filter and update_by_filter generic tests to haystack.testing.document_store#10477
Merged
davidsbatista merged 23 commits intomainfrom Feb 5, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
davidsbatista
changed the title
delete_all_documents tests to DeleteDocumentsTest mixindelete_all_documents tests to DeleteDocumentsTest mixin
Collaborator
Pull Request Test Coverage Report for Build 21717270304Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
davidsbatista
changed the title
delete_all_documents tests to DeleteDocumentsTest mixindelete_all_documents, delete_by_filter update_by_filter tests to DeleteDocumentsTest mixin
anakin87
reviewed
Feb 4, 2026
anakin87
reviewed
Feb 4, 2026
davidsbatista
changed the title
delete_all_documents, delete_by_filter update_by_filter tests to DeleteDocumentsTest mixindelete_all_documents, delete_by_filter update_by_filter tests to haystack.testing.document_store
davidsbatista
changed the title
delete_all_documents, delete_by_filter update_by_filter tests to haystack.testing.document_storedelete_all_documents, delete_by_filter and update_by_filter generic tests to haystack.testing.document_store
anakin87
reviewed
Feb 5, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
It's looking good.
I left a few minor comments.
Co-authored-by: Stefano Fiorucci <[email protected]>
anakin87
reviewed
Feb 5, 2026
anakin87
approved these changes
Feb 5, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thanks for all the adjustments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
delete_all_documents():normal behaviour, empty store, and optional recreate_index (True/False).delete_by_filter():matching docs, no matches, and AND/OR filters.UpdateByFilterTestforupdate_by_filter(): basic update, no matches, multiple fields, and AND/OR filters.DocumentStoreBaseTestsincludesUpdateByFilterTestHow did you test it?
haystack-core-integrationsand made sure all passedpytest.skip()when a store doesn’t implement delete_all_documents, delete_by_filter, or update_by_filter, or when recreate_index isn’t supported.NOTE:
This needs to be merged before deepset-ai/haystack-core-integrations#2812 is merged into
haystack-core-integrationsChecklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.