Skip to content

Comments

fix: add retry for server disconnect#106

Merged
ArzelaAscoIi merged 4 commits intomainfrom
fix/retryServerDisconnect
Sep 7, 2023
Merged

fix: add retry for server disconnect#106
ArzelaAscoIi merged 4 commits intomainfrom
fix/retryServerDisconnect

Conversation

@ArzelaAscoIi
Copy link
Member

Related Issues

  • hotfix

Proposed Changes?

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Coverage report

The coverage rate went from 92.86% to 92.89% ⬆️
The branch rate is 80%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

deepset_cloud_sdk/_s3/upload.py

100% of new lines are covered (91.25% of the complete file).

@ArzelaAscoIi ArzelaAscoIi changed the title tests: add test for failing fix: add retry for server disconnect Sep 7, 2023
@ArzelaAscoIi ArzelaAscoIi merged commit e917f5f into main Sep 7, 2023
@ArzelaAscoIi ArzelaAscoIi deleted the fix/retryServerDisconnect branch September 7, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ton of ServerDisconnectedErrors against HTTPS AWS S3 REST API

2 participants