Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Update Transformers to 4.6.1#787

Merged
julian-risch merged 2 commits intomasterfrom
update-transformers-4.6.1
Jun 2, 2021
Merged

Update Transformers to 4.6.1#787
julian-risch merged 2 commits intomasterfrom
update-transformers-4.6.1

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Jun 1, 2021

  • Run tests
  • Run benchmark

closes #786

@julian-risch julian-risch changed the title Update Transformers to 4.6.1 WIP: Update Transformers to 4.6.1 Jun 1, 2021
@Timoeller
Copy link
Copy Markdown
Contributor

I like unpinning the Transformers version but it might create strange behavior. E.g. some models/fast tokenizers (e.g. for BigBird) are just available in 4.5.0++ and we do not rigorously test for all model + tokenizer cases in combination with our tasks.

If we unpin the version we will first need to invest some time for extensive tests and a CI that checks for all (minor) versions.

@Timoeller Timoeller self-requested a review June 2, 2021 16:43
@julian-risch julian-risch marked this pull request as ready for review June 2, 2021 16:45
@julian-risch julian-risch changed the title WIP: Update Transformers to 4.6.1 Update Transformers to 4.6.1 Jun 2, 2021
Copy link
Copy Markdown
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

Changes in training for NER (with only 4 sentences and 4 entities) should be related to under the hood changes to optimizers. So Im fine with adjusting the assertions manually in this case.

@julian-risch julian-risch merged commit 840d310 into master Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Transformers to 4.6.1

3 participants