This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Added value of doc_stride, max_seq_len, max_query_length in error message#784
Merged
Timoeller merged 1 commit intodeepset-ai:masterfrom May 28, 2021
Conversation
Timoeller
approved these changes
May 28, 2021
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
Nice, thanks for the addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am experimenting with different max_seq_len and max_query_length and I think it is nice to have information about these value in case of negative assertion.