This repository was archived by the owner on Apr 8, 2025. It is now read-only.
perf(DPR-Data-Read): Improve data reading process#733
Merged
Timoeller merged 2 commits intodeepset-ai:masterfrom Mar 5, 2021
Merged
perf(DPR-Data-Read): Improve data reading process#733Timoeller merged 2 commits intodeepset-ai:masterfrom
Timoeller merged 2 commits intodeepset-ai:masterfrom
Conversation
Support jsonl format, downsampling data, add passage id when not exist.
Timoeller
reviewed
Mar 4, 2021
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
Looks very good already. Thanks for the changes.
- lets keep max samples
- made a comment about a failing test
Although the downsampling now exists twice in our codebase I vote for keeping the downsampling in our TextSimilarityProcessor as wll, since we might use it for other datasets. Or do you have any strong preferences?
Timoeller
approved these changes
Mar 5, 2021
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
Very nice, thanks for the suggested changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to issue #730
Improvement: