This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Conversation
Timoeller
changed the title
Contributor
Author
|
@overlookcurl please have a look at this PR. There is also a new test for how to do TextpairRegression. I have tested it and it should work, at least the MSE went done rather splendidly. We will merge this soon, if you do not want to wait you could test it out on this branch already :D |
tholor
approved these changes
Feb 11, 2021
Member
tholor
left a comment
tholor
left a comment
There was a problem hiding this comment.
Nice one! Just left one suggestion for a further test case...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes Text Pair classification by combining text and text_b in the proper way.
PR also adds text pair regression and accompanying tests.
fixes #701
fixes #688