This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Re-enable test_dpr_modules also for windows.#697
Merged
Timoeller merged 1 commit intodeepset-ai:masterfrom Jan 26, 2021
Merged
Conversation
Timoeller
approved these changes
Jan 26, 2021
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
Nice, good suggestion!
I suggest to keep it to the windows user to install latest pytorch (in our reqs.txt there is torch>1.5,<1.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello this PR is related to the closes isuue #637.
@Timoeller: I tested in my CI pipeline that with pytorch version 1.7.1, and test_dpr_modules succeed on Windows, so probably as you pointed out from version 1.7.0 DDP is supported also in windows.
So, now that FARM makes use of pytorch 1.7.* it is desiderable to re-eanble this test for all operating system.