This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Conversation
added 2 commits
January 7, 2021 11:06
Comparison of gold label answers and answers defined by start/end indices does not consider leading and trailing whitespaces anymore
There was a warning about too long input sequences, which is now surpressed. The encoded sequences are processed with striding afterward. Encoded sequences are not passed in full length to the model and therefore do not cause problems.
Timoeller
reviewed
Jan 7, 2021
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
Looks good.
Still there might be a logging bug on transformer side that we should investigate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tokenizer's call of the tokenize_batch_question_answering method caused warnings of untruncated input sequences. These warnings are now ignored because the encoded sequences are processed in strides afterward and truncation is therefore not needed.
Further, an input validation step for QA data had a bug where whitespaces were not correctly handled when comparing gold label texts with texts at the start/end indices. Leading and trailing whitespaces are now ignored
#673