This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Replace 'none' titles with empty string in DPR#663
Merged
Conversation
Timoeller
approved these changes
Dec 28, 2020
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
I think this code makes FARM DPR more failsafe, so lets merge it.
We will need to refactor TextSimilarityProcessor and move the processing into dataset_from_dicts, as done with the other processors. Lets do this in a new PR
| for title, ctx in zip(titles, texts): | ||
| if title is None: | ||
| title = "" | ||
| logger.warning( |
Contributor
There was a problem hiding this comment.
This warning would be triggered for every datapoint if the title is missing.
Contributor
|
Mhh dpr tests still failing, will need to investigate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPR preprocessing crashed in cases where
embed_title=Truebut the incoming passages did not have a title.Now, we replace those titles with an empty string and log a warning...