Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

MLFlowLogger can be disabled#650

Merged
brandenchan merged 3 commits intomasterfrom
disable_logger
Dec 4, 2020
Merged

MLFlowLogger can be disabled#650
brandenchan merged 3 commits intomasterfrom
disable_logger

Conversation

@brandenchan
Copy link
Copy Markdown
Contributor

Related to #616.

To disable MLFlow logging, you simply call MLFLowLogger.disable(). ML Logging is now turned off in the Inferencer by default.

Copy link
Copy Markdown
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a code comment.

Apart from that, many tests are failing, then it OOMs with code 137. Can this be related to these changes?

farm/utils.py Outdated
This class can be extended to implement custom logging backends like MLFlow, Tensorboard, or Sacred.
"""

disable = False
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that needed?

Copy link
Copy Markdown
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandenchan brandenchan merged commit 1ae1b71 into master Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants