This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Refactor DPR for haystack compatibility#606
Merged
Conversation
* fix removal of yes no answers * Make use of the answer_type linked to each answers. * pin seqeval version * remove hardcoded answer types list Co-authored-by: Fabio Tesser <[email protected]> Co-authored-by: Malte Pietsch <[email protected]>
tholor
reviewed
Oct 27, 2020
* Inference model and tokenizer type from config * Infer type from model name as fallback
tholor
changed the title
tholor
approved these changes
Oct 28, 2020
Member
tholor
left a comment
tholor
left a comment
There was a problem hiding this comment.
Looking good. Once CI passes, we can merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_seq_len_queryandmax_seq_len_contextadded to TextSimilarityProcessor