This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Merged
Conversation
Timoeller
suggested changes
Oct 20, 2020
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
Lets remove hard coded answer types as suggested in comment.
Contributor
|
Hey sorry @brandenchan but this is not the best solution. We have an empty list as default arg which is an anti pattern, see https://docs.python-guide.org/writing/gotchas/ Otherwise the solution is ok with me. |
tholor
added a commit
that referenced
this pull request
Oct 28, 2020
* DPRProcessor, BiAdaptiveModel modified for optional query/passage * TextSimilarityProcessor, BiAdaptiveModel haystack inference compatibility added * TextSimilarityProcessor query/passage features optional * DPRProcessor, BiAdaptiveModel modified for optional query/passage * TextSimilarityProcessor, BiAdaptiveModel haystack inference compatibility added * TextSimilarityProcessor query/passage features optional * prediction head modified * bugfix in BiAdaptiveModel init * Fix removal of yes no answers (#540) * fix removal of yes no answers * Make use of the answer_type linked to each answers. * pin seqeval version * remove hardcoded answer types list Co-authored-by: Fabio Tesser <[email protected]> Co-authored-by: Malte Pietsch <[email protected]> * DPR test modified for max_seq_len_query/max_seq_len_context * Infer model type from config (#600) * Inference model and tokenizer type from config * Infer type from model name as fallback * BiAdaptive model output type modified to tuple from dict * dpr tests reflect biadaptive model output type(tuple) * DPRProcessor, BiAdaptiveModel modified for optional query/passage * TextSimilarityProcessor, BiAdaptiveModel haystack inference compatibility added * TextSimilarityProcessor query/passage features optional * DPRProcessor, BiAdaptiveModel modified for optional query/passage * TextSimilarityProcessor, BiAdaptiveModel haystack inference compatibility added * prediction head modified * bugfix in BiAdaptiveModel init * DPR test modified for max_seq_len_query/max_seq_len_context * BiAdaptive model output type modified to tuple from dict * dpr tests reflect biadaptive model output type(tuple) * renamed variables from 'context' to 'passage' * DPR language model loading refactored * DPR Language model comments fix Co-authored-by: Branden Chan <[email protected]> Co-authored-by: Fabio Tesser <[email protected]> Co-authored-by: Malte Pietsch <[email protected]> Co-authored-by: bogdankostic <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, yes no answers in the Natural Questions dataset were being converted into span answers (#529). This PR fixes this problem.