This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Add asserts on doc_stride and max_seq_len to prevent issues with sliding window#538
Merged
brandenchan merged 1 commit intomasterfrom Sep 14, 2020
Merged
Add asserts on doc_stride and max_seq_len to prevent issues with sliding window#538brandenchan merged 1 commit intomasterfrom
brandenchan merged 1 commit intomasterfrom
Conversation
tholor
reviewed
Sep 14, 2020
tholor
approved these changes
Sep 14, 2020
Timoeller
approved these changes
Sep 14, 2020
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
I think it is good for merging, just made a comment to the caught exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where the doc_stride is greater than the number of passage tokens in the sliding window, an index error may be thrown. See #536 and #510. This PR adds asserts to avoid these situations.
Note that the number of passage tokens is computed as follows:
max_seq_len - question_tokens - special tokens