This repository was archived by the owner on Apr 8, 2025. It is now read-only.
fix Natural Question inference processing#521
Merged
Conversation
Contributor
|
Yup this quick fix is sufficient for now. There will be a bigger refactor coming where we merge the SQuAD and NQ processors. There we can more accurately define the supported inference input. We should also write tests to ensure that each inference input format works. |
Contributor
Author
|
k, thanks for the input. Merging this now as fix. |
Timoeller
changed the title
brandenchan
suggested changes
Sep 7, 2020
Contributor
brandenchan
left a comment
brandenchan
left a comment
There was a problem hiding this comment.
Apart from changing the input file, this all looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extracting IDs from the input we run into errors.
This is a quick fix fixing #520 catching the exception, since we do not need these IDs.
We should investigate for a better solution and create NQ test cases for training and inferencing @brandenchan