This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Add Dense Passage Retriever (incl. Training)#513
Merged
Conversation
tholor
suggested changes
Sep 4, 2020
Member
tholor
left a comment
There was a problem hiding this comment.
Thanks for the first draft for the processor. Let's iterate on it as there are quite some design decisions to be discussed.
tholor
reviewed
Sep 4, 2020
tholor
suggested changes
Oct 15, 2020
Member
tholor
left a comment
There was a problem hiding this comment.
Looking good! Left a few comment for smaller changes.
Plus there's one bigger topic left: refactoring the conversion of DPR from/to transformers to the new FARM style introduced in #576 (see my comment). However, I think we can tackle that one better in a separate PR.
tholor
approved these changes
Oct 15, 2020
Member
tholor
left a comment
There was a problem hiding this comment.
Thanks for the changes. Looking good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide functionality for Dense Passage Retrieval training
TO_DO:
Tokenization
DPRContextEncoderTokenizerandDPRQuestionEncoderTokenizerDPRProcessor:
with
embed_title = Falsewith
embed_title=True_sample_to_features
file_to_dict: reads json in DPR format and returns list of dictionaries
-Usage:
using fast tokenizer: