This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Conversation
tholor
approved these changes
Aug 31, 2020
Member
tholor
left a comment
tholor
left a comment
There was a problem hiding this comment.
Seems reasonable! Did you try running it and checked whether the timing is now more consistent?
Member
|
I did a test run and the timing seems now consistent 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw cases where the first run in the loop of question_answering_components.py took longer or showed different time profile characteristics. This PR adds a warm up run in order to combat this fluctuation, which we suspect comes from the GPU warming up.