This repository was archived by the owner on Apr 8, 2025. It is now read-only.
fix _initialize_data_loaders in data_silo#476
Merged
Timoeller merged 1 commit intodeepset-ai:masterfrom Aug 17, 2020
Merged
Conversation
Timoeller
suggested changes
Jul 29, 2020
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
This is a very useful bugfix. Thanks for the addition.
Please just correct one small typo and we are good to merge
Contributor
|
Hey @rohanag , did you have time to look into it? If not I will happyly take over, push the small change and merge myself. |
Contributor
Author
|
Oops, thanks for spotting the typo. I'll be away from my laptop for a few days, so please go ahead and fix :) |
1 similar comment
Contributor
Author
|
Oops, thanks for spotting the typo. I'll be away from my laptop for a few days, so please go ahead and fix :) |
rohanag
force-pushed
the
rohanag/silo-fix
branch
from
d91aeac to
84c4899
Compare
Contributor
Author
|
@Timoeller fixed! |
Contributor
|
Hey thanks for fixing yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug manifests when calling data_silo.load_data() with train, test and dev_dicts and processor is not initialized with file names for train, test and dev.