This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Remove baskets without features in _create_dataset.#471
Merged
brandenchan merged 1 commit intodeepset-ai:masterfrom Jul 22, 2020
Merged
Remove baskets without features in _create_dataset.#471brandenchan merged 1 commit intodeepset-ai:masterfrom
brandenchan merged 1 commit intodeepset-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a new PR in substitution of #461 and it is about #457.
In this new PR, I created a static method to check if all samples in a basket have features.
In this way we stop to iterate in the samples of basket when the first sample has features None (we save some cycles in this way).
If this method returns True we can add all samples to features_flat, otherwise, later the basket is removed from self.baskets.