This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Remove assertions or replace with logging error#468
Merged
brandenchan merged 1 commit intomasterfrom Jul 22, 2020
Merged
Conversation
Timoeller
approved these changes
Jul 22, 2020
Contributor
Author
|
See #444 for some earlier discussions around the topic |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR either removes asserts or replaces them with logging errors. The idea behind this is to improve the stability of FARM in production so that it doesn't crash halfway through a long inference or training job. Asserts that check initialization of components are maintained.