This repository was archived by the owner on Apr 8, 2025. It is now read-only.
farm.data_handler.utils: Add encoding to open write in split_file method#466
Merged
Timoeller merged 4 commits intodeepset-ai:masterfrom Jul 27, 2020
Merged
farm.data_handler.utils: Add encoding to open write in split_file method#466Timoeller merged 4 commits intodeepset-ai:masterfrom
Timoeller merged 4 commits intodeepset-ai:masterfrom
Conversation
Updating Fork
split_file - add encoding to open write file
Update utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FARM version, the encoding is only used during open read in the method split_file, but not when open file for write at line 784 and 793. This caused an error when splitting a file with UTF-8 encoding, which shouldn't happen considering the method itself required an encoding as input parameter (which is default to UTF-8).
I've tested this revision with my text file (which caused error before the revision), and the split process works fine afterwards.
Fixes #462