This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Ensure QAInferencer always has task_type "question_answering"#460
Merged
brandenchan merged 3 commits intomasterfrom Jul 15, 2020
Merged
Ensure QAInferencer always has task_type "question_answering"#460brandenchan merged 3 commits intomasterfrom
brandenchan merged 3 commits intomasterfrom
Conversation
Timoeller
approved these changes
Jul 15, 2020
Contributor
Timoeller
left a comment
Timoeller
left a comment
There was a problem hiding this comment.
looking good. Minor change in the warning message needed.
Lets change this once we have multiple types of QA styles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though the parent Inferencer class can set task_type to one of many values, it should always be "question_answering" in the QAInferencer. This PR enforces this and gives a warning when a user tries to initialise the class with a different value