Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

fix bugs with regression label standardization#456

Merged
Timoeller merged 1 commit intodeepset-ai:masterfrom
rohanag:rohanag/regression-head-fix
Jul 14, 2020
Merged

fix bugs with regression label standardization#456
Timoeller merged 1 commit intodeepset-ai:masterfrom
rohanag:rohanag/regression-head-fix

Conversation

@rohanag
Copy link
Copy Markdown
Contributor

@rohanag rohanag commented Jul 10, 2020

fixes #452

@Timoeller Timoeller self-requested a review July 13, 2020 09:55
@Timoeller Timoeller self-assigned this Jul 13, 2020
Timoeller
Timoeller approved these changes Jul 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
Tested the code on a small regression dataset.

Thanks for the improvements @rohanag

@Timoeller Timoeller merged commit b98884d into deepset-ai:master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Timoeller Timoeller Timoeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Timoeller Timoeller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

regression processor label standardization inconsistencies

2 participants

@rohanag @Timoeller