Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

WIP: Input Objects#445

Merged
brandenchan merged 19 commits intomasterfrom
input_objects
Jul 9, 2020
Merged

WIP: Input Objects#445
brandenchan merged 19 commits intomasterfrom
input_objects

Conversation

@brandenchan
Copy link
Copy Markdown
Contributor

@brandenchan brandenchan commented Jul 6, 2020

The goal of this object is to create classes that contain the input to QA models so that the interface between FARM and Haystack can be more easily tested. This involves also adding more tests that can be replicated in Haystack in order to ensure compatibility

Copy link
Copy Markdown
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking very good already, just some minor adjustments needed.

Lets wait for the CI to run through before merging

@brandenchan
Copy link
Copy Markdown
Contributor Author

Benchmarks pass

@brandenchan brandenchan merged commit 431d0b8 into master Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants