This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Fix bug in benchmark tests with if statement#430
Merged
tanaysoni merged 2 commits intodeepset-ai:masterfrom Jul 8, 2020
Merged
Fix bug in benchmark tests with if statement#430tanaysoni merged 2 commits intodeepset-ai:masterfrom
tanaysoni merged 2 commits intodeepset-ai:masterfrom
Conversation
9 tasks
Contributor
|
Hi @PhilipMay, thank you for raising this fix! I did a minor change on your branch to make it more readable. If you think it's okay, then this PR is good-to-go. |
Contributor
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I found a strange bug. Can you please review this?
I am not 100% sure if it is fixed now.