This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Closed
Conversation
brandenchan
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that tokenization of sentences containing special characters, especially characters from different languages, can cause token_offsets to contain non increasing offset indices. See test_tokenization.py for examples of problematic sentences.
This is caused by tokenizers' handling of unseen characters. RoBERTa's tokenizer sometimes turns one char into two (presumably through bit level encoding) and BERT converts some chars into "[UNK]" which is counted as 5 chars.