Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Improvements to Natural Questions#411

Merged
brandenchan merged 14 commits intomasterfrom
nq_2
Jun 24, 2020
Merged

Improvements to Natural Questions#411
brandenchan merged 14 commits intomasterfrom
nq_2

Conversation

@brandenchan
Copy link
Copy Markdown
Contributor

@brandenchan brandenchan commented Jun 17, 2020

Implements a set of clean up and performance changes for Natural Questions

  • SQuAD and NQ basket formats unified
  • ID passing simplified
  • deduplicate apply_tokenization() in SQuAD and NQ processors
  • delete unused functions

@brandenchan brandenchan changed the title WIP: Improvements to Natural Questions Improvements to Natural Questions Jun 18, 2020
@brandenchan brandenchan requested a review from tholor June 18, 2020 16:28
@brandenchan brandenchan requested a review from Timoeller June 22, 2020 13:06
@brandenchan
Copy link
Copy Markdown
Contributor Author

Benchmark tests in question_answering_accuracy.py now pass

Copy link
Copy Markdown
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Timoeller
Copy link
Copy Markdown
Contributor

Improvements to passing of ids will be handled in a different PR.

@brandenchan brandenchan merged commit 50284db into master Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants