This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Registration and parametrization for evaluation reports#331
Merged
tholor merged 4 commits intodeepset-ai:masterfrom Apr 24, 2020
gsarti:custom-report-metrics
Merged
Registration and parametrization for evaluation reports#331tholor merged 4 commits intodeepset-ai:masterfrom gsarti:custom-report-metrics
tholor merged 4 commits intodeepset-ai:masterfrom
gsarti:custom-report-metrics
Conversation
Member
|
Hey @gsarti , Thanks for working on this! I like the changes and would just propose some smaller adjustments (see my commit 536f1c3):
What do you think about these changes? Happy to merge this, when you are fine with it. |
gsarti
commented
Apr 22, 2020
tanaysoni
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Added registering and param for eval report * Fix registered ph output types bug * rename to register_report(). change order in checks. add docstring and error message * fix typo Co-authored-by: Malte Pietsch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #325 that was deemed as interesting by maintainers:
metrics.py, refactoring it into the ad-hoc functioncompute_report_metrics.register_ph_output_typeinsidemetrics.pyto allow for custom metric registration in the context of evaluation reports.eval_reportparameter in theTrainerclass to allow switching off reporting whenevaluate_everyparam is > 0.