This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Make multiprocessing attributes an instance property of Inferencer#329
Merged
Make multiprocessing attributes an instance property of Inferencer#329
Conversation
tanaysoni
added a commit
that referenced
this pull request
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, for each execution of
Inferencer.inference_from_dicts()we create and tear-down an instance ofmultiprocessing.Pool. This leads to problems when using the Inferencer in HTTP frameworks like FastAPI/Uvicorn/Gunicorn stack.To address the issue, this PR makes changes to initialize a
multiprocessing.Poolat the class-instance level of Inferencer. ThisPoolgets re-used for all inference requests.With the new changes, the
num_processesis supplied as an argument when loading an Inferencer instead of supplying it ininference_from_dicts().