This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Conversation
tanaysoni
changed the title
tholor
suggested changes
Apr 24, 2020
Member
tholor
left a comment
tholor
left a comment
There was a problem hiding this comment.
Would be great to add:
- a small readme with instructions on how to run (e.g. which env needed for onnx?)
- writing the results somewhere to a file / table than we can link in the repo and update after releases / major changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an automated speed benchmarking pipeline using pytest-benchmark.
As a first benchmark, a test case is added comparing inference latency for Question Answering using PyTorch vs ONNX against different combinations of
batch_sizeandmax_seq_len.Additionally, this PR also fixes the test for multiprocessing in the
Inferencer.TODO