Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Setting num_training_steps in schedule_opts is not good in function initialize_optimizer #436

@PhilipMay

Description

@PhilipMay

This line:

schedule_opts["num_training_steps"] = num_train_optimization_steps

is not nice when the API user sets an explicit schedule_opts dictionary. It overwrites values. IMO it should be deleted.
What do you think?

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions