Skip to content

Conversation

@jscanvic
Copy link
Collaborator

@jscanvic jscanvic commented Jul 21, 2025

Towards #487

Coverage

  • Global: 82.8 ➡️ 83.1 (+0.3)
  • deepinv.models.unet: 50.6 ➡️ 77.0 (+26.4)
  • deepinv.optim.phase_retrieval: 10.3 ➡️ 38.0 (+27.7)

Improvements

  • Test BFBatchNorm2d in deepinv.models.unet
  • Refactor the UNet forward methods (some of them being untested) into one
  • Improve coverage of deepinv.optim.phase_retrieval

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

❌ Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (55bc94f) to head (032b9cf).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deepinv/models/unet.py 82.14% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   82.93%   83.29%   +0.36%     
==========================================
  Files         195      195              
  Lines       18042    17993      -49     
  Branches     2408     2407       -1     
==========================================
+ Hits        14963    14988      +25     
+ Misses       2259     2175      -84     
- Partials      820      830      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jscanvic jscanvic force-pushed the increase_unet_coverage branch from 48083db to 87aae7e Compare July 21, 2025 21:14
@jscanvic jscanvic mentioned this pull request Jul 21, 2025
2 tasks
@jscanvic jscanvic changed the title Increase UNet code coverage Miscelaneous code coverage improvements Jul 21, 2025
@jscanvic
Copy link
Collaborator Author

jscanvic commented Nov 8, 2025

(Not happy with how it ended up looking - closing)

@jscanvic jscanvic closed this Nov 8, 2025
@jscanvic jscanvic mentioned this pull request Dec 6, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant