-
Notifications
You must be signed in to change notification settings - Fork 133
docstring return denoise_diffusion #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 81.13% 81.13%
=======================================
Files 195 195
Lines 17793 17793
Branches 2381 2381
=======================================
Hits 14436 14436
Misses 2555 2555
Partials 802 802 ☔ View full report in Codecov by Sentry. |
tachella
approved these changes
Jul 11, 2025
Tmodrzyk
pushed a commit
to Tmodrzyk/deepinv
that referenced
this pull request
Jul 17, 2025
jscanvic
added a commit
to jscanvic/deepinv
that referenced
this pull request
Aug 4, 2025
commit d479673 Author: Andrewwango <[email protected]> Date: Mon Aug 4 10:27:47 2025 +0100 docs for new thresholding commit 428c5e9 Author: Andrewwango <[email protected]> Date: Mon Aug 4 10:11:40 2025 +0100 Update deepinv/models/ram.py commit 4ff9e8d Merge: f1da894 fdab7ce Author: Matthieu Terris <[email protected]> Date: Sun Aug 3 17:54:09 2025 +0200 merge norm commit f1da894 Author: Matthieu Terris <[email protected]> Date: Sun Aug 3 17:29:09 2025 +0200 norm commit fdab7ce Author: Andrewwango <[email protected]> Date: Fri Aug 1 22:49:14 2025 +0100 add multi-physics models to user guide commit 76f1624 Author: Andrewwango <[email protected]> Date: Fri Aug 1 22:49:01 2025 +0100 fix doc commit 574379d Author: Andrewwango <[email protected]> Date: Fri Aug 1 22:32:31 2025 +0100 black commit 3fb4cad Merge: 90f7620 25224a4 Author: Andrewwango <[email protected]> Date: Fri Aug 1 22:32:21 2025 +0100 Merge branch 'main' into ram commit 90f7620 Author: Andrewwango <[email protected]> Date: Fri Aug 1 22:31:03 2025 +0100 julian comments commit 25224a4 Author: Andrewwango <[email protected]> Date: Fri Aug 1 18:48:19 2025 +0100 More MRI, more downsampling, and more fixes (deepinv#608) * modify downsampling and its generator * better imsize handling and update_parameters in downsampling * deal with imsize better * update warning * fastmri better raw transform * bug * nan * fastmri data is so annoying * doc * temp * fastmri docstrings * changelog * fix downsampling tests * fix test + doc bug * better raw mri tour * allow batched filter strings * placeholder imsize_dynamic * fix * submodule add imresize * add matlab downsampling * small fix to trainer * minor fixes * fastmri bugfix * fix lpips and niqe * minor dtype * fix cmrxrecon mistake * skmtea dataset! * spelling * update skmtea + small bib * add skmtea to init * skmtea docs * skmtea test * changelog + fix ruff * downsampling matlab docs * Remove submodule * tests + remove imresize * remove import * remove gitmodules * fastmri tests * downsamplingmatlab tests * fix example * fix * jeremy comments 1 * imresive uses backprop adjoint + fix tests * fix ruff * Update deepinv/datasets/fastmri.py Co-authored-by: Minh Hai Nguyen <[email protected]> * hai comments + fix doctest * ruff * add div2k performance test * fix * temp * rerun ci --------- Co-authored-by: Minh Hai Nguyen <[email protected]> commit 5738b03 Author: Jérémy Scanvic <[email protected]> Date: Fri Aug 1 10:59:47 2025 +0200 Fix deepinv#634 (deepinv#637) * fix device inference in GaussianNoise * pass kwargs down super in LinearPhysics * Revert "pass kwargs down super in LinearPhysics" This reverts commit 49b3e5e. A better fix is featured in 8d08d86 * exclude GPU-only branch from coverage * fix the other noise models * fix set initialization * fix types syntax * change the assert into a RuntimeError * add TensorList support commit d8189a6 Author: Minh Hai Nguyen <[email protected]> Date: Thu Jul 31 22:46:46 2025 +0200 Update library dependencies, issue template, codecov on linux only (deepinv#654) * codecov linux only and adding uv * mv wandb to optional dependency * rm hdf5storage, add h5py to datasets * add device for pytest * mv natsort to datasets * finished dependencies * update issue template * changelog * uv not supported on github * requests is needed * update import error check * update import error check * codecov ignore import optinal modules * last changes * issue template * h5py back to dependency * discord --------- Co-authored-by: mh-nguyen712 <[email protected]> commit 99526f0 Author: vsechaud <[email protected]> Date: Thu Jul 31 17:42:00 2025 +0200 Fix for Issue deepinv#647 – UNet uses zero-padding even when it shouldn't (deepinv#653) * fix bug unet padding mode * black unet file * change log commit 3569ab3 Author: Jérémy Scanvic <[email protected]> Date: Thu Jul 31 15:57:45 2025 +0200 Fixing tests on GPU (deepinv#569) * create pr * fix test_dataloader_formats * fix test_trainer_physics_generator_params * fix test_trainer_multidatasets * fix test_trainer_identity * black * fix test_DEQ * fix test_inpainting_generators * fix test_metrics * fix test_wavelet_decomposition * black * fix test_noise_model * black * fix None-related bug * making rng states buffers again * specify dtype as well * revert changes made in test_wavelet_decomposition * Revert "revert changes made in test_wavelet_decomposition" This reverts commit 9bc2a3b. commit 55bc94f Author: Jérémy Scanvic <[email protected]> Date: Wed Jul 30 22:03:29 2025 +0200 Add a missing line in the docs (deepinv#632) * add missing param in the docs * fix the docstring * add missing import * silence a weird sphinx warning commit 9d28b63 Author: Matthieu Terris <[email protected]> Date: Wed Jul 30 11:01:40 2025 +0200 fix commit 183513a Author: Minh Hai Nguyen <[email protected]> Date: Tue Jul 29 22:26:53 2025 +0200 Fix memory leak (deepinv#651) * start * fix * fix * changelog --------- Co-authored-by: mh-nguyen712 <[email protected]> commit 8636b1d Author: Matthieu Terris <[email protected]> Date: Tue Jul 29 18:45:35 2025 +0200 clean commit 8e1c3ef Author: Matthieu Terris <[email protected]> Date: Tue Jul 29 18:35:36 2025 +0200 thresholding commit 9c9a31c Author: Matthieu Terris <[email protected]> Date: Mon Jul 28 19:23:09 2025 +0200 black commit bd724af Author: Matthieu Terris <[email protected]> Date: Mon Jul 28 19:20:37 2025 +0200 max commit 44ed2ab Author: Matthieu Terris <[email protected]> Date: Mon Jul 28 19:18:15 2025 +0200 max commit 54f8edd Author: Matthieu Terris <[email protected]> Date: Mon Jul 28 18:02:53 2025 +0200 abs tensorlist commit 88e3c17 Author: Matthieu Terris <[email protected]> Date: Mon Jul 28 15:37:40 2025 +0200 norm commit 2f9ff55 Merge: b70d651 7116f70 Author: Matthieu Terris <[email protected]> Date: Mon Jul 28 10:36:16 2025 +0200 normalize commit b70d651 Author: Matthieu Terris <[email protected]> Date: Mon Jul 28 10:28:42 2025 +0200 normalize commit 7116f70 Author: Jérémy Scanvic <[email protected]> Date: Sun Jul 27 18:55:29 2025 +0200 Remove ignored arguments (deepinv#640) * CLN warn user about unused parameters in Physics * CLN move kwargs to physics * TST check that the warning is raised * FIX linting * black * get rid of ignored arguments * get rid of ignored arguments * get rid of ignored arguments * get rid of no-ops --------- Co-authored-by: tommoral <[email protected]> Co-authored-by: Andrewwango <[email protected]> commit a7bc80a Author: Matthieu Terris <[email protected]> Date: Sun Jul 27 17:11:50 2025 +0200 black commit 8d08d86 Author: Thomas Moreau <[email protected]> Date: Sun Jul 27 17:06:10 2025 +0200 CLN warn user about unused parameters in Physics (deepinv#423) * CLN warn user about unused parameters in Physics * CLN move kwargs to physics * TST check that the warning is raised * FIX linting * black --------- Co-authored-by: Andrewwango <[email protected]> commit bafc63d Author: Matthieu Terris <[email protected]> Date: Sun Jul 27 16:57:11 2025 +0200 black commit a1ddacc Merge: dfa2477 09be3a9 Author: Matthieu Terris <[email protected]> Date: Sun Jul 27 16:56:49 2025 +0200 merge main commit dfa2477 Author: Matthieu Terris <[email protected]> Date: Sun Jul 27 16:54:45 2025 +0200 cleaning commit 0853fe8 Author: Matthieu Terris <[email protected]> Date: Sun Jul 27 15:14:03 2025 +0200 comments commit f815630 Author: Matthieu Terris <[email protected]> Date: Sun Jul 27 14:55:45 2025 +0200 revert commit f7814c0 Author: Matthieu Terris <[email protected]> Date: Sun Jul 27 13:41:20 2025 +0200 failing test but good idea commit 09be3a9 Author: Jérémy Scanvic <[email protected]> Date: Sat Jul 26 13:49:48 2025 +0200 Make zips strict (deepinv#635) * enable zip-without-explicit-strict rule in ruff * make zip calls strict * black * replace zips on key-values by items calls * black commit 735bed7 Author: Fedor <[email protected]> Date: Fri Jul 25 14:02:44 2025 +0200 added a warning in the doc for get_freer_gpu (deepinv#570) * added warning in the doc * added str literal, changed doc sentences; changed set/no set behaviour * full code refactor * fixed black/added changelog * typo in changelog * reorder arguments for backwards compatibility * adapt the tests to a behavior change * test new arguments --------- Co-authored-by: Jérémy Scanvic <[email protected]> Co-authored-by: Jérémy Scanvic <[email protected]> commit 28a6c33 Author: Jérémy Scanvic <[email protected]> Date: Fri Jul 25 13:51:02 2025 +0200 Warn against default interpolation mode in `deepinv.transform.Rotate` (deepinv#633) * add a warning for default interpolation mode * black commit d48e26b Author: Andrewwango <[email protected]> Date: Thu Jul 24 18:09:48 2025 +0100 Tiny spelling (deepinv#631) commit 55ca5fc Author: Jérémy Scanvic <[email protected]> Date: Thu Jul 24 16:06:51 2025 +0200 Flag unused imports in CI (deepinv#557) * create pr * enable rule F401 of ruff in continuous integration * run ruff --fix on unused imports * black * run unsafe ruff fix * black * fix the 4 last errors manually * disable ruff for an import with side effects * black * ignore ruff false positive for fixture * black * trigger ci * ignore ruff false positive for (other) fixture * apply ruff safe fix ruff check --target-version "py310" --fix --select "F401" * apply ruff unsafe fix ruff check --target-version "py310" --preview --fix --unsafe-fixes --select "F401" * black * get rid of no-op * add missing import * add missing import * restore __init__.py files from the main branch git restore --source=upstream/main -- '**/__init__.py' * disable the unused imports rules for init files * apply ruff safe fix ruff check --target-version "py310" --fix --select "F401" * restore mistakenly removed imports commit b3743f0 Author: Julián Tachella <[email protected]> Date: Thu Jul 24 16:05:46 2025 +0200 fix (deepinv#630) commit a113107 Author: Julián Tachella <[email protected]> Date: Tue Jul 22 18:20:17 2025 +0200 readd online docs push commit da1d8fe Author: Samuel Hurault <[email protected]> Date: Tue Jul 22 14:55:26 2025 +0200 Add bibtex style cite for references (deepinv#575) * ref bib * add refs to loss * refs * continue bib * continue bib * black * examples refs * end cites * black * changelog * black * fixes * fixes * toml * toml * dncnn * merge * docs * docs * docs * merge * dataset refs * dataset refs * agha * refs * black * corr refs * corr refs * pb refs * merge * remove refs from first line in class doc * black * fix bugs refs * black * add sep * black * revert old noisy data fid * black * line pb * black * try * change bib style * change bib style * correct build docs * repeadted entry * docstring guidelines * andrews comments * paper part problem for docs --> move to start of contributinc.rst * andrew comment * add automatically the ref to examples * black * update some refs * remove REF in examples * black * change citation style GAN example * change citation style GAN example * update bib and correction julian * Juli{\a}n * corret refs * Update CHANGELOG.rst Co-authored-by: Andrewwango <[email protected]> * Andrews comments * Update examples/self-supervised-learning/demo_ei_transforms.py Co-authored-by: Julián Tachella <[email protected]> * Update deepinv/loss/moi.py Co-authored-by: Julián Tachella <[email protected]> * Update deepinv/transform/scale.py Co-authored-by: Julián Tachella <[email protected]> --------- Co-authored-by: Samuel Hurault <[email protected]> Co-authored-by: Andrewwango <[email protected]> Co-authored-by: Julián Tachella <[email protected]> commit 75f140d Author: Matthieu Terris <[email protected]> Date: Mon Jul 21 21:27:27 2025 +0200 andrews comments commit fcc45a1 Author: Matthieu Terris <[email protected]> Date: Mon Jul 21 20:13:05 2025 +0200 julians comments commit ce1f56e Author: Jérémy Scanvic <[email protected]> Date: Mon Jul 21 12:58:41 2025 +0200 Increase test coverage of `deepinv.utils` (deepinv#555) * test phantom datasets * test tensor list dirac_like * get rid of bleeding edge parameter strict in zip * improve coverage of plotting functions and fix bugs * add tests for plot_curves * test plot_parameters * add test parameters and fix bugs * test resize_pad_square_tensor and torch2cpu * test get_freer_gpu * get rid of mistakenly commited files * test deprecation of deepinv.utils.metric functions * fix typo * test load_degradation * test load_dataset * export deepinv.utils.parameters members in deepinv.utils * test test_get_GSPnP_params * test ProgressMeter * test tensorlist methods * test load_image * change deprecated tmpdir to standard tmp_path * fix the tests on CPU-only devices * improve non-idiomatic code * trigger ci * restore demos * pin sphinx_sitemap to v2.6.0 see deepinv#508 and deepinv#555 * make variable names more consistent * black * merge non_interactive_matplotlib and no_plot * black commit 488df3a Author: Thibaut Modrzyk <[email protected]> Date: Mon Jul 21 10:56:41 2025 +0200 Add support for new parameters in ``plot_inset`` (deepinv#611) * Add support for new parameters in ``plot_inset`` Now the parameters match the one used in ``plot``. * Add fig and axs parameters * Fix docstring * Enable intersphinx mapping for Matplotlib commit 871f690 Author: mathurinm <[email protected]> Date: Mon Jul 21 10:46:25 2025 +0200 DOC pass on DPS example (deepinv#612) * DOC dps example * simpler alphas/betas handling * Apply suggestions from code review * black + minor tweaks * widehat x_t > widehat x_0 * typo * Update examples/sampling/demo_dps.py commit 4671cb9 Author: Matthieu Terris <[email protected]> Date: Sat Jul 19 14:37:33 2025 +0200 doctests commit f5a5b01 Author: Matthieu Terris <[email protected]> Date: Sat Jul 19 13:30:03 2025 +0200 comments commit 86f75fa Author: Matthieu Terris <[email protected]> Date: Sat Jul 19 12:12:33 2025 +0200 comments commit 8061545 Author: Matthieu Terris <[email protected]> Date: Sat Jul 19 12:08:17 2025 +0200 docs api commit 6cece22 Author: Matthieu Terris <[email protected]> Date: Sat Jul 19 10:45:39 2025 +0200 docs api commit 0446b0d Author: Matthieu Terris <[email protected]> Date: Sat Jul 19 00:25:33 2025 +0200 docs api commit f70c314 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 22:47:11 2025 +0200 docs api commit bdc3b85 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 20:28:05 2025 +0200 jk Im back commit 4030bf0 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 19:48:59 2025 +0200 bye commit 0fea485 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 19:39:18 2025 +0200 api autosummary + docs commit 7c17b77 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 19:26:52 2025 +0200 ram denoise + gamma -> gain commit 088bd41 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 18:59:06 2025 +0200 add tests upsampling commit 338ddb5 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 18:58:54 2025 +0200 add tests upsampling commit 1a15f57 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 17:29:32 2025 +0200 fix tests commit 52b22e3 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 15:37:43 2025 +0200 tests ram commit 99379cf Author: Andrewwango <[email protected]> Date: Fri Jul 18 11:53:34 2025 +0100 Tiny modifications to repo-level things (deepinv#616) * fix contrib * remove version from citation commit 64dfb69 Merge: e7d748a 464ec13 Author: Matthieu Terris <[email protected]> Date: Fri Jul 18 09:06:09 2025 +0200 Merge branch 'main' into ram commit 464ec13 Author: mathurinm <[email protected]> Date: Fri Jul 18 07:12:20 2025 +0200 add __all__ to __about__.py (deepinv#615) commit ece6368 Author: Minh Hai Nguyen <[email protected]> Date: Fri Jul 18 00:22:47 2025 +0200 Update python version to 3.10+ (deepinv#605) * Export all changes: workflow updates, pyproject.toml changes to py>=310 * rm torch version dependency * update * changelog * py version as str * py version in lint * debug * debug py311 * torch27 * torch>=2.2.0 * save_path in n2n example * update python version in badge * merge main --------- Co-authored-by: mh-nguyen712 <[email protected]> commit 67b4d37 Author: Minh Hai Nguyen <[email protected]> Date: Thu Jul 17 16:28:21 2025 +0200 Link to download the built doc for PRs (deepinv#613) * download url of built doc * syntax * comment artifact * comment not working * simple solution * update contrib guide * rm workflow * changes commit 16c599f Author: mathurinm <[email protected]> Date: Wed Jul 16 13:57:07 2025 +0200 DOC add size requirement for pretrained diffunet (deepinv#610) * add size requirement for pretrained diffunet * Update deepinv/models/diffunet.py * Update deepinv/models/diffunet.py * Apply suggestions from code review * black trailing whitespaces * cosmit forward diffusion commit 98c5df0 Author: Julián Tachella <[email protected]> Date: Wed Jul 16 13:15:24 2025 +0200 remove circle ci + add pr docs predisplay (deepinv#607) * remove circle ci + modify docs push * hai comments + contributing guidelines * fix yaml * edit if message exists * yaml refix * prpreview cleanup * try sth * fix * fix again * fix * try sth 2 * fix again * try * and now * ahhh * add permission * fix link * fix link * move to end * add tip commit e7d748a Author: Matthieu Terris <[email protected]> Date: Sat Jul 12 17:31:51 2025 +0200 test circleci commit fda1224 Author: Matthieu Terris <[email protected]> Date: Sat Jul 12 17:01:11 2025 +0200 test circleci commit f304b6a Author: romainvo <[email protected]> Date: Sat Jul 12 07:25:29 2025 +0200 Remove unused nf argument in DRUNet. Complete doc and indicate that DRUNet has a fixed number of scales. (deepinv#603) commit 387e4cc Author: mathurinm <[email protected]> Date: Fri Jul 11 11:50:05 2025 +0200 docstring return denoise_diffusion (deepinv#600) commit aa74b9a Merge: 36e91a3 35b0745 Author: Matthieu Terris <[email protected]> Date: Mon Jul 7 13:02:53 2025 +0200 merge main commit 36e91a3 Author: Matthieu Terris <[email protected]> Date: Mon Jul 7 12:57:40 2025 +0200 docs + tests
jscanvic
pushed a commit
that referenced
this pull request
Aug 10, 2025
* Remove the size parameter in calls to plt.suptitle and set_title
* Add the cpu option in the trainer, the default being cuda if a gpu is available. All tensors in the example are on the cpu, so if the system has an available GPU the example breaks and the associated doc can't be generated.
* Other errors in the examples, related to the device when a GPU is available, mix up between cpu and cuda.
* Add the ansmath package to the tex environment of matlplotlib so that lines containing \text{} compile correctly
* Further device errors in examples when building with a GPU available
* Call to config_matplotlib in conf.py + remove default fontsize value in plot parameters
* Set figure title fontsize and axes title fontsize explicitely in ``config_matplotlib``
When using seaborn, fontsize had again no effect on the fontsize of the titles, but only on suptitles.
Now one can use seaborn and still control the fontsize of the titles.
* trigger CI docs rerun
* fix demo_tou_mri.py example on gpu
* remove matplotlib fontsize 9
* fix example demove_remote_sensing on GPU
* docstring return denoise_diffusion (#600)
* Remove unused nf argument in DRUNet. Complete doc and indicate that DRUNet has a fixed number of scales. (#603)
* remove circle ci + add pr docs predisplay (#607)
* remove circle ci + modify docs push
* hai comments + contributing guidelines
* fix yaml
* edit if message exists
* yaml refix
* prpreview cleanup
* try sth
* fix
* fix again
* fix
* try sth 2
* fix again
* try
* and now
* ahhh
* add permission
* fix link
* fix link
* move to end
* add tip
* DOC add size requirement for pretrained diffunet (#610)
* add size requirement for pretrained diffunet
* Update deepinv/models/diffunet.py
* Update deepinv/models/diffunet.py
* Apply suggestions from code review
* black trailing whitespaces
* cosmit forward diffusion
* Link to download the built doc for PRs (#613)
* download url of built doc
* syntax
* comment artifact
* comment not working
* simple solution
* update contrib guide
* rm workflow
* changes
* trigger CI docs rerun
* Another fix to set fontsize globally in the docs
My previous solution for the global fontsize was still overwritten by new calls to ``setup_matplotlib``
* fix plot_ortho3D default fontsize
* fix layout issues causing cutoff of long titles
* Various fixes in examples
* fix horizontal display issue + css improvements
* fix css again
* add little margin to the figures
---------
Co-authored-by: mathurinm <[email protected]>
Co-authored-by: romainvo <[email protected]>
Co-authored-by: Julián Tachella <[email protected]>
Co-authored-by: Minh Hai Nguyen <[email protected]>
Co-authored-by: Andrewwango <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #599