-
Notifications
You must be signed in to change notification settings - Fork 133
Open
Labels
good first issueGood for newcomers - well-scoped, easy issue.Good for newcomers - well-scoped, easy issue.priority: lowNice to have, non-urgent issue or PR.Nice to have, non-urgent issue or PR.
Description
As discussed with @Andrewwango in PR #611, the functions plot and plot_inset now share many overlapping features and parameters
We see two solutions:
- merge into one function
plotwith optional parameters for the insets - lump all the parameters of
plotinto a**plot_kwargsin the declaration ofplot_inset
I think both approaches have trade-offs:
- breaks backward compatibility, meaning all current uses of
plot_insethave to be fixed manually - preserves backward compatibility, but makes the API less transparent. Users need to consult
plot's docstring to know what parameters they can use inplot_inset
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomers - well-scoped, easy issue.Good for newcomers - well-scoped, easy issue.priority: lowNice to have, non-urgent issue or PR.Nice to have, non-urgent issue or PR.